fixed and resolved todos
This commit is contained in:
parent
4b2e96a992
commit
88dd18428b
@ -74,9 +74,11 @@ class ManiaExchangeManager {
|
||||
trigger_error($mysqli->error);
|
||||
return;
|
||||
}
|
||||
$saveMapStatement->bind_param('is', $mapMxId, $mapUId);
|
||||
foreach($mxMapInfos as $mxMapInfo) {
|
||||
/** @var MXMapInfo $mxMapInfo */
|
||||
$saveMapStatement->bind_param('is', $mxMapInfo->id, $mxMapInfo->uid);
|
||||
$mapMxId = $mxMapInfo->id;
|
||||
$mapUId = $mxMapInfo->uid;
|
||||
$saveMapStatement->execute();
|
||||
if ($saveMapStatement->error) {
|
||||
trigger_error($saveMapStatement->error);
|
||||
@ -89,9 +91,11 @@ class ManiaExchangeManager {
|
||||
$uid = $mxMapInfo->uid;
|
||||
}
|
||||
$map = $this->maniaControl->mapManager->getMapByUid($uid);
|
||||
|
||||
/** @var Map $map */
|
||||
$map->mx = $mxMapInfo;
|
||||
if ($map) {
|
||||
// TODO: how does it come that $map can be empty here? we got an error report for that
|
||||
/** @var Map $map */
|
||||
$map->mx = $mxMapInfo;
|
||||
}
|
||||
}
|
||||
$saveMapStatement->close();
|
||||
}
|
||||
|
@ -537,6 +537,8 @@ class UpdateManager implements CallbackListener, CommandListener, TimerListener
|
||||
$self->maniaControl->log('[UPDATE] Successfully updated ' . $pluginData->name . '!');
|
||||
if ($player) {
|
||||
$self->maniaControl->chat->sendSuccess('Successfully updated ' . $pluginData->name . '!', $player->login);
|
||||
// FIXME: the property $pluginData->pluginClass doesn't exist
|
||||
// TODO: to update a plugin you need to restart maniacontrol, otherwise the new file isn't loaded by php
|
||||
$self->maniaControl->pluginManager->deactivatePlugin($pluginData->pluginClass);
|
||||
$self->maniaControl->pluginManager->activatePlugin($pluginData->pluginClass);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user