beu
/
TrackManiaControl
1
0
Fork 0
Code Issues 9 Pull Requests Releases Wiki Activity

add default permission check for admin commands

This commit is contained in:
Beu 2023-11-25 16:07:35 +01:00
parent afe617b642
commit 251988b19b
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
core/Commands/CommandManager.php
View File

@ -2,8 +2,10 @@
namespace ManiaControl\Commands; namespace ManiaControl\Commands;
use ManiaControl\Admin\AuthenticationManager;
use ManiaControl\Callbacks\CallbackListener; use ManiaControl\Callbacks\CallbackListener;
use ManiaControl\Callbacks\CallbackManager; use ManiaControl\Callbacks\CallbackManager;
use ManiaControl\Callbacks\Callbacks;
use ManiaControl\Callbacks\Listening; use ManiaControl\Callbacks\Listening;
use ManiaControl\General\UsageInformationAble; use ManiaControl\General\UsageInformationAble;
use ManiaControl\General\UsageInformationTrait; use ManiaControl\General\UsageInformationTrait;
@ -18,6 +20,10 @@ use ManiaControl\ManiaControl;
*/ */
class CommandManager implements CallbackListener, UsageInformationAble { class CommandManager implements CallbackListener, UsageInformationAble {
use UsageInformationTrait; use UsageInformationTrait;
/*
* Constants
*/
const SETTING_PERMISSION_ADMIN_COMMANDS = "Minimum permissions level to use admin commands";
/* /*
* Private properties * Private properties
@ -48,6 +54,12 @@ class CommandManager implements CallbackListener, UsageInformationAble {
// Callbacks // Callbacks
$this->maniaControl->getCallbackManager()->registerCallbackListener(CallbackManager::CB_MP_PLAYERCHAT, $this, 'handleChatCallback'); $this->maniaControl->getCallbackManager()->registerCallbackListener(CallbackManager::CB_MP_PLAYERCHAT, $this, 'handleChatCallback');
$this->maniaControl->getCallbackManager()->registerCallbackListener(Callbacks::AFTERINIT, $this, 'handleAfterInit');
}
public function handleAfterInit() {
// Permissions
$this->maniaControl->getAuthenticationManager()->definePermissionLevel(self::SETTING_PERMISSION_ADMIN_COMMANDS, AuthenticationManager::AUTH_LEVEL_MODERATOR, AuthenticationManager::AUTH_LEVEL_PLAYER);
} }
/** /**
@ -327,6 +339,11 @@ class CommandManager implements CallbackListener, UsageInformationAble {
$isAdminCommand = true; $isAdminCommand = true;
$commandListenings = $this->adminCommandListenings; $commandListenings = $this->adminCommandListenings;
if (!$this->maniaControl->getAuthenticationManager()->checkPermission($player, self::SETTING_PERMISSION_ADMIN_COMMANDS)) {
$this->maniaControl->getAuthenticationManager()->sendNotAllowed($player);
return;
}
if ($command === 'admin') { if ($command === 'admin') {
// Strip 'admin' keyword // Strip 'admin' keyword
if (isset($commandArray[1])) { if (isset($commandArray[1])) {