changed direct public property access to using getter methods

phpdoc improvements

application/core/Server/Commands.php

@@ -43,6 +43,7 @@ class Commands implements CallbackListener, CommandListener, ManialinkPageAnswer
 	/*
 	 * Private properties
 	 */
+	/** @var ManiaControl $maniaControl */
 	private $maniaControl = null;
 	private $serverShutdownTime = -1;
 	private $serverShutdownEmpty = false;

application/core/Server/Directory.php

@@ -15,9 +15,10 @@ use ManiaControl\ManiaControl;
  * @license   http://www.gnu.org/licenses/ GNU General Public License, Version 3
  */
 class Directory implements CallbackListener {
-	/**
+	/*
 	 * Private properties
 	 */
+	/** @var ManiaControl $maniaControl */
 	private $maniaControl = null;
 
 	/**

application/core/Server/ScriptManager.php

@@ -13,8 +13,9 @@ use ManiaControl\ManiaControl;
  */
 class ScriptManager {
 	/*
-	 * Private Properties
+	 * Private properties
 	 */
+	/** @var ManiaControl $maniaControl */
 	private $maniaControl = null;
 	private $isScriptMode = null;
 

application/core/Server/Server.php

@@ -35,19 +35,25 @@ class Server implements CallbackListener {
 	public $login = null;
 	public $titleId = null;
 	/** @var Directory $directory */
+	/** @deprecated see getDirectory() */
 	public $directory = null;
 	/** @var Commands $commands */
+	/** @deprecated see getCommands() */
 	public $commands = null;
 	/** @var UsageReporter $usageReporter */
+	/** @deprecated see getUsageReporter() */
 	public $usageReporter = null;
 	/** @var RankingManager $rankingManager */
+	/** @deprecated see getRankingManager() */
 	public $rankingManager = null;
 	/** @var ScriptManager $scriptManager */
+	/** @deprecated see getScriptManager() */
 	public $scriptManager = null;
 
 	/*
-	 * Private Properties
+	 * Private properties
 	 */
+	/** @var ManiaControl $maniaControl */
 	private $maniaControl = null;
 	private $teamMode = null;
 
@@ -133,6 +139,15 @@ class Server implements CallbackListener {
 		return $this->usageReporter;
 	}
 
+	/**
+	 * Return the ranking manager
+	 *
+	 * @return RankingManager
+	 */
+	public function getRankingManager() {
+		return $this->rankingManager;
+	}
+
 	/**
 	 * Return the script manager
 	 *
@@ -284,7 +299,7 @@ class Server implements CallbackListener {
 	 * @return string
 	 */
 	public function getGhostReplay($login) {
-		$dataDir = $this->directory->getGameDataFolder();
+		$dataDir = $this->getDirectory()->getGameDataFolder();
 		if (!$this->checkAccess($dataDir)) {
 			return null;
 		}

application/core/Server/ServerOptionsMenu.php

@@ -46,6 +46,7 @@ class ServerOptionsMenu implements CallbackListener, ConfiguratorMenu, TimerList
 	/*
 	 * Private properties
 	 */
+	/** @var ManiaControl $maniaControl */
 	private $maniaControl = null;
 
 	/**

application/core/Server/UsageReporter.php

@@ -22,8 +22,9 @@ class UsageReporter implements TimerListener {
 	const SETTING_REPORT_USAGE = 'Report Usage to $lManiaControl.com$l';
 
 	/*
-	 * Private Properties
+	 * Private properties
 	 */
+	/** @var ManiaControl $maniaControl */
 	private $maniaControl = null;
 
 	/**

application/core/Server/VoteRatiosMenu.php

@@ -31,6 +31,7 @@ class VoteRatiosMenu implements CallbackListener, ConfiguratorMenu, TimerListene
 	/*
 	 * Private properties
 	 */
+	/** @var ManiaControl $maniaControl */
 	private $maniaControl = null;
 
 	/**