beu/TrackManiaControl
1
0
Fork 0
Code Issues 10 Pull Requests Releases Wiki Activity

Refactoring of Code, Comments and Spelling

Browse Source
This commit is contained in:
Steffen Schröder
2013-12-09 13:45:58 +01:00
parent 5339b6766f
commit c97b4166f2
26 changed files with 1834 additions and 1833 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
application/core/Admin/AdminMenu.php
View File

@ -4,7 +4,6 @@ namespace ManiaControl\Admin;
use ManiaControl\ManiaControl;
use ManiaControl\Callbacks\CallbackListener;
use ManiaControl\Callbacks\CallbackManager;
use FML\ManiaLink;
use FML\Controls\Control;
use FML\Controls\Frame;
@ -136,7 +135,7 @@ class AdminMenu implements CallbackListener {
// Add items
$x = 0.5 * $itemSize * $itemMarginFactorX;
foreach ($this->menuItems as $itemOrder => $menuItems) {
foreach ($this->menuItems as $menuItems) {
foreach ($menuItems as $menuItem) {
$menuItem->setSize($itemSize, $itemSize);
$itemsFrame->add($menuItem);

17
application/core/Admin/AuthCommands.php
View File

@ -6,6 +6,11 @@ use ManiaControl\ManiaControl;
use ManiaControl\Commands\CommandListener;
use ManiaControl\Players\Player;
/**
* Class offering commands to grant authorizations to players
*
* @author steeffeen & kremsy
*/
class AuthCommands implements CommandListener {
/**
* Private properties
@ -50,7 +55,7 @@ class AuthCommands implements CommandListener {
}
$success = $this->maniaControl->authenticationManager->grantAuthLevel($player, AuthenticationManager::AUTH_LEVEL_SUPERADMIN);
if (!$success) {
$this->maniaControl->chat->sendError('Error occured.', $player->login);
$this->maniaControl->chat->sendError('Error occurred.', $player->login);
return;
}
$message = '$<' . $player->nickname . '$> added $<' . $target->nickname . '$> as SuperAdmin!';
@ -81,7 +86,7 @@ class AuthCommands implements CommandListener {
}
$success = $this->maniaControl->authenticationManager->grantAuthLevel($player, AuthenticationManager::AUTH_LEVEL_ADMIN);
if (!$success) {
$this->maniaControl->chat->sendError('Error occured.', $player->login);
$this->maniaControl->chat->sendError('Error occurred.', $player->login);
return;
}
$message = '$<' . $player->nickname . '$> added $<' . $target->nickname . '$> as Admin!';
@ -112,7 +117,7 @@ class AuthCommands implements CommandListener {
}
$success = $this->maniaControl->authenticationManager->grantAuthLevel($player, AuthenticationManager::AUTH_LEVEL_OPERATOR);
if (!$success) {
$this->maniaControl->chat->sendError('Error occured.', $player->login);
$this->maniaControl->chat->sendError('Error occurred.', $player->login);
return;
}
$message = '$<' . $player->nickname . '$> added $<' . $target->nickname . '$> as Operator!';
@ -127,7 +132,7 @@ class AuthCommands implements CommandListener {
*/
private function sendAddSuperAdminUsageInfo(Player $player) {
$message = "Usage Example: '//addsuperadmin login'";
return $this->maniaControl->chat->sendUsageInfo($message);
return $this->maniaControl->chat->sendUsageInfo($message, $player->login);
}
/**
@ -138,7 +143,7 @@ class AuthCommands implements CommandListener {
*/
private function sendAddAdminUsageInfo(Player $player) {
$message = "Usage Example: '//addadmin login'";
return $this->maniaControl->chat->sendUsageInfo($message);
return $this->maniaControl->chat->sendUsageInfo($message, $player->login);
}
/**
@ -149,7 +154,7 @@ class AuthCommands implements CommandListener {
*/
private function sendAddOperatorUsageInfo(Player $player) {
$message = "Usage Example: '//addop login'";
return $this->maniaControl->chat->sendUsageInfo($message);
return $this->maniaControl->chat->sendUsageInfo($message, $player->login);
}
}

6
application/core/Admin/AuthenticationManager.php
View File

@ -133,9 +133,9 @@ class AuthenticationManager {
}
/**
* Sends an error message to the login
* Sends an error message to the player
*
* @param string $login
* @param Player $player
* @return bool
*/
public function sendNotAllowed(Player $player) {
@ -148,7 +148,7 @@ class AuthenticationManager {
/**
* Check if the player has enough rights
*
* @param \ManiaControl\Players\Player $login
* @param Player $player
* @param int $neededAuthLevel
* @return bool
*/