coding & phpdoc improvements continued

This commit is contained in:
Steffen Schröder
2014-05-27 22:44:22 +02:00
parent 9e016cc770
commit c284feb843
12 changed files with 23 additions and 40 deletions

View File

@ -146,10 +146,9 @@ class ChatMessagePlugin implements CommandListener, Plugin {
* @return mixed
*/
private function getTarget($login) {
/** @var Player $player */
$player = null;
foreach ($this->maniaControl->playerManager->getPlayers() as $player) {
if ($login == $player && $login == $player->login || $login == $player->pid || $login == $player->nickname) {
if ($login == $player || $login == $player->login || $login == $player->pid || $login == $player->nickname) {
return $player->nickname;
}
}

View File

@ -305,7 +305,7 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
return null;
}
if (count($this->maniaControl->playerManager->getPlayers()) == 0) {
if ($this->maniaControl->playerManager->getPlayerCount(false) <= 0) {
return null;
}
@ -326,7 +326,6 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
}
$playerInfo = array();
foreach ($players as $player) {
/** @var Player $player */
array_push($playerInfo, array('Login' => $player->login, 'IsSpec' => $player->isSpectator));
}
return $playerInfo;

View File

@ -362,7 +362,6 @@ class KarmaPlugin implements CallbackListener, TimerListener, Plugin {
$properties['getvotesonly'] = false;
$properties['playerlogins'] = array();
foreach ($this->maniaControl->playerManager->getPlayers() as $loopPlayer) {
/** @var Player $loopPlayer */
$properties['playerlogins'][] = $loopPlayer->login;
}
} else {

View File

@ -400,7 +400,6 @@ class ServerRankingPlugin implements Plugin, CallbackListener, CommandListener {
$this->resetRanks();
foreach ($this->maniaControl->playerManager->getPlayers() as $player) {
/** @var Player $player */
if ($player->isFakePlayer()) {
continue;
}

View File

@ -306,25 +306,13 @@ class WidgetPlugin implements CallbackListener, TimerListener, Plugin {
$backgroundQuad->setSize($width, $height);
$backgroundQuad->setStyles($quadStyle, $quadSubstyle);
$maxPlayers = $this->maniaControl->client->getMaxPlayers();
$maxSpectators = $this->maniaControl->client->getMaxSpectators();
$serverName = $this->maniaControl->client->getServerName();
$players = $this->maniaControl->playerManager->getPlayers();
$playerCount = 0;
$spectatorCount = 0;
/**
* @var Player $player
*/
foreach ($players as $player) {
if ($player->isSpectator) {
$spectatorCount++;
} else {
$playerCount++;
}
}
$playerCount = $this->maniaControl->playerManager->getPlayerCount(true);
$maxPlayers = $this->maniaControl->client->getMaxPlayers();
$spectatorCount = $this->maniaControl->playerManager->getSpectatorCount();
$maxSpectators = $this->maniaControl->client->getMaxSpectators();
$label = new Label_Text();
$frame->add($label);