beu/TrackManiaControl
1
0
Fork 0
Code Issues 11 Pull Requests Releases Wiki Activity

phpdoc + coding improvements #3

Browse Source
This commit is contained in:
Steffen Schröder 2014-05-27 23:00:39 +02:00
parent 8b89289784
commit 736507fccf
6 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
application/core/Configurators/ManiaControlSettings.php
View File

@ -128,8 +128,6 @@ class ManiaControlSettings implements ConfiguratorMenu, CallbackListener {
$index = 0; $index = 0;
$y = 0; $y = 0;
foreach ($settings as $setting) { foreach ($settings as $setting) {
/** @var Setting $setting */
if (!$pageFrame) { if (!$pageFrame) {
$pageFrame = new Frame(); $pageFrame = new Frame();
$frame->add($pageFrame); $frame->add($pageFrame);

2
application/core/Maps/MapCommands.php
View File

@ -113,7 +113,7 @@ class MapCommands implements CommandListener, ManialinkPageAnswerListener, Callb
$requester = $nextQueued[0]; $requester = $nextQueued[0];
/** @var Map $map */ /** @var Map $map */
$map = $nextQueued[1]; $map = $nextQueued[1];
$this->maniaControl->chat->sendInformation("Next Map is $<{$map->nam}$> from $<{$map->authorNick}$> requested by $<{$requester->nickname}$>.", $player); $this->maniaControl->chat->sendInformation("Next Map is $<{$map->name}$> from $<{$map->authorNick}$> requested by $<{$requester->nickname}$>.", $player);
} else { } else {
$mapIndex = $this->maniaControl->client->getNextMapIndex(); $mapIndex = $this->maniaControl->client->getNextMapIndex();
$maps = $this->maniaControl->mapManager->getMaps(); $maps = $this->maniaControl->mapManager->getMaps();

2
application/core/Server/Server.php
View File

@ -153,7 +153,7 @@ class Server implements CallbackListener {
/** /**
* Gets all Servers from the Database * Gets all Servers from the Database
* *
* @return array * @return \stdClass[]
*/ */
public function getAllServers() { public function getAllServers() {
$mysqli = $this->maniaControl->database->mysqli; $mysqli = $this->maniaControl->database->mysqli;

6
application/core/Settings/SettingManager.php
View File

@ -429,7 +429,7 @@ class SettingManager implements CallbackListener {
* Get all Settings for the given Class * Get all Settings for the given Class
* *
* @param mixed $object * @param mixed $object
* @return array * @return Setting[]
*/ */
public function getSettingsByClass($object) { public function getSettingsByClass($object) {
$className = ClassUtil::getClass($object); $className = ClassUtil::getClass($object);
@ -453,7 +453,7 @@ class SettingManager implements CallbackListener {
/** /**
* Get all Settings * Get all Settings
* *
* @return array * @return Setting[]
*/ */
public function getSettings() { public function getSettings() {
$mysqli = $this->maniaControl->database->mysqli; $mysqli = $this->maniaControl->database->mysqli;
@ -476,7 +476,7 @@ class SettingManager implements CallbackListener {
* Get all Setting Classes * Get all Setting Classes
* *
* @param bool $hidePluginClasses * @param bool $hidePluginClasses
* @return array * @return string[]
*/ */
public function getSettingClasses($hidePluginClasses = false) { public function getSettingClasses($hidePluginClasses = false) {
$mysqli = $this->maniaControl->database->mysqli; $mysqli = $this->maniaControl->database->mysqli;

2
application/core/Update/UpdateManager.php
View File

@ -85,7 +85,7 @@ class UpdateManager implements CallbackListener, CommandListener, TimerListener
/** /**
* Get the possible Update Channels * Get the possible Update Channels
* *
* @return array * @return string[]
*/ */
public function getUpdateChannels() { public function getUpdateChannels() {
// TODO: change default channel on release // TODO: change default channel on release

7
application/plugins/MCTeam/Dedimania/DedimaniaPlugin.php
View File

@ -1123,11 +1123,10 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
* @return array|RecordData * @return array|RecordData
*/ */
public function getDedimaniaRecords() { public function getDedimaniaRecords() {
if (!$this->dedimaniaData->records) { if ($this->dedimaniaData->records) {
return null; return $this->dedimaniaData->records;
} }
$records = $this->dedimaniaData->records; return null;
return $records;
} }
/** /**