beu/TrackManiaControl
1
0
Fork 0
Code Issues 7 Pull Requests Releases Wiki Activity

improved closure code & phpdoc

Browse Source
This commit is contained in:
Steffen Schröder
2014-05-27 22:19:47 +02:00
parent e23c795fc9
commit 5df32fa657
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
application/core/ManiaExchange/ManiaExchangeManager.php
View File

@@ -143,7 +143,7 @@ class ManiaExchangeManager {
* Get the Whole MapList from MX by Mixed Uid and Id String fetch * Get the Whole MapList from MX by Mixed Uid and Id String fetch
* *
* @param string $string * @param string $string
* @return array|null * @return bool
*/ */
public function getMaplistByMixedUidIdString($string) { public function getMaplistByMixedUidIdString($string) {
// Get Title Prefix // Get Title Prefix
@@ -155,18 +155,17 @@ class ManiaExchangeManager {
$thisRef = $this; $thisRef = $this;
$success = $this->maniaControl->fileReader->loadFile($url, function ($mapInfo, $error) use ($thisRef, $titlePrefix, $url) { $success = $this->maniaControl->fileReader->loadFile($url, function ($mapInfo, $error) use ($thisRef, $titlePrefix, $url) {
if ($error) { if ($error) {
trigger_error($error . " " . $url); trigger_error("Error: '{$error}' for Url '{$url}'");
return null; return;
} }
if (!$mapInfo) { if (!$mapInfo) {
return null; return;
} }
$mxMapList = json_decode($mapInfo); $mxMapList = json_decode($mapInfo);
if ($mxMapList === null) { if ($mxMapList === null) {
trigger_error('Cannot decode searched JSON data from ' . $url); trigger_error("Can't decode searched JSON Data from Url '{$url}'");
return null; return;
} }
$maps = array(); $maps = array();
@@ -180,7 +179,6 @@ class ManiaExchangeManager {
} }
$thisRef->updateMapObjectsWithManiaExchangeIds($maps); $thisRef->updateMapObjectsWithManiaExchangeIds($maps);
return true;
}, "application/json"); }, "application/json");
return $success; return $success;