beu/TrackManiaControl
1
0
Fork 0
Code Issues 10 Pull Requests Releases Wiki Activity

deprecated getSetting method to keep third-party plugin compatibility

Browse Source
This commit is contained in:
Steffen Schröder
2014-05-13 22:54:26 +02:00
parent 23c58b47ff
commit 55a3ac446a
3 changed files with 23 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
application/core/Settings/SettingManager.php
View File

@ -136,7 +136,7 @@ class SettingManager implements CallbackListener {
public function setSetting($object, $settingName, $value) {
$className = ClassUtil::getClass($object);
$setting = $this->getSetting($object, $settingName);
$setting = $this->getSettingObject($object, $settingName);
if ($setting) {
$setting->value = $value;
if (!$this->saveSetting($setting)) {
@ -162,7 +162,7 @@ class SettingManager implements CallbackListener {
* @param mixed $default
* @return Setting
*/
public function getSetting($object, $settingName, $default = null) {
public function getSettingObject($object, $settingName, $default = null) {
$settingClass = ClassUtil::getClass($object);
// Retrieve from Storage if possible
@ -262,6 +262,14 @@ class SettingManager implements CallbackListener {
return true;
}
/**
* @deprecated
* @see SettingManager::getSettingValue()
*/
public function getSetting($object, $settingName, $default = null) {
return $this->getSettingValue($object, $settingName, $default);
}
/**
* Get the Setting Value directly
*
@ -271,7 +279,7 @@ class SettingManager implements CallbackListener {
* @return mixed
*/
public function getSettingValue($object, $settingName, $default = null) {
$setting = $this->getSetting($object, $settingName, $default);
$setting = $this->getSettingObject($object, $settingName, $default);
if ($setting) {
return $setting->value;
}