Code Cleanup

application/ManiaControl.php

@@ -1,5 +1,4 @@
 <?php
-use ManiaControl\ManiaControl;
 
 // Define base dir
 define('ManiaControlDir', __DIR__);
@@ -11,8 +10,10 @@ if (function_exists('date_default_timezone_get') && function_exists('date_defaul
 }
 
 // Error handling
-ini_set('log_errors', 1);
+ini_set('log_errors', true);
+ini_set('display_errors', '1');
 ini_set('error_reporting', -1);
+ini_set('display_startup_errors', true);
 if (!is_dir('logs')) {
 	mkdir('logs');
 }
@@ -22,9 +23,7 @@ ini_set('error_log', 'logs/ManiaControl_' . getmypid() . '.log');
 require_once __DIR__ . '/core/ManiaControl.php';
 
 // Start ManiaControl
-error_log('Loading ManiaControl v' . ManiaControl::VERSION . '...');
+error_log('Loading ManiaControl v' . ManiaControl\ManiaControl::VERSION . '...');
 
-$maniaControl = new ManiaControl();
+$maniaControl = new ManiaControl\ManiaControl();
 $maniaControl->run();
-
-?>

application/core/GbxDataFetcher/gbxdatafetcher.inc.php

@@ -1428,4 +1428,4 @@ class GBXPackFetcher extends GBXBaseFetcher
 	}  // processGBX
 
 }  // class GBXPackFetcher
-?>
+

application/core/ManiaExchange/mxinfofetcher.inc.php

@@ -303,4 +303,4 @@ class MXInfoFetcher {
 		}
 	}  // get_file
 }  // class MXInfoFetcher
-?>
+

application/core/ManiaExchange/mxinfosearcher.inc.php

@@ -322,4 +322,4 @@ class MXInfo {
 		}
 	}  // MXInfo
 }  // class MXInfo
-?>
+

application/core/Maps/MapCommands.php

@@ -151,6 +151,7 @@ class MapCommands implements CommandListener {
 			return true;
 		}
 		// TODO: add local map by filename
+        return false;
 	}
 
 	/**

application/core/PhpRemote/GbxRemote.bem.php

@@ -889,4 +889,3 @@ function big_endian_unpack($format, $data) {
 	}
 	return $ar;
 }
-?>

application/core/PhpRemote/GbxRemote.inc.php

@@ -852,4 +852,4 @@ class IXR_ClientMulticall_Gbx extends IXR_Client_Gbx {
 		return $result;
 	}
 }
-?>
+

application/plugins/Chatlog.php

@@ -140,5 +140,3 @@ class ChatlogPlugin implements CallbackListener, Plugin {
 		file_put_contents($this->fileName, $message, FILE_APPEND);
 	}
 }
-
-?>

application/plugins/Donations.php

@@ -274,5 +274,3 @@ class DonationPlugin implements CallbackListener, CommandListener, Plugin {
 		return $this->maniaControl->chat->sendChat($message, $player->login);
 	}
 }
-
-?>

application/plugins/Endurance.php

@@ -125,5 +125,3 @@ class EndurancePlugin implements CallbackListener, Plugin {
 		$this->maniaControl->callbackManager->triggerCallback(CallbackManager::CB_TM_PLAYERFINISH, $finishCallback);
 	}
 }
-
-?>

application/plugins/Karma.php

@@ -472,5 +472,3 @@ class KarmaPlugin implements CallbackListener, Plugin {
 		$this->manialink = $manialink;
 	}
 }
-
-?>

application/plugins/LocalRecords.php

@@ -407,4 +407,3 @@ class LocalRecordsPlugin implements CallbackListener, Plugin {
 	}
 }
 
-?>

application/plugins/Obstacle.php

@@ -139,5 +139,3 @@ class ObstaclePlugin implements CallbackListener, CommandListener, Plugin {
 		$this->maniaControl->callbackManager->triggerCallback(CallbackManager::CB_TM_PLAYERCHECKPOINT, $finishCallback);
 	}
 }
-
-?>