beu/TrackManiaControl
1
0
Fork 0
Code Issues 7 Pull Requests Releases Wiki Activity

removed some resolved todos

Browse Source
This commit is contained in:
kremsy
2014-01-14 18:27:54 +01:00
committed by Steffen Schröder
parent 145f612a2f
commit 41dabc21a3
5 changed files with 35 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
application/core/Admin/ActionsMenu.php
View File

@@ -123,7 +123,6 @@ class ActionsMenu implements CallbackListener, ManialinkPageAnswerListener {
if(!$this->initCompleted) { if(!$this->initCompleted) {
return; return;
} }
// TODO: Render only once
$players = $this->maniaControl->playerManager->getPlayers(); $players = $this->maniaControl->playerManager->getPlayers();
foreach($players as $player) { foreach($players as $player) {
$manialink = $this->buildMenuIconsManialink($player); $manialink = $this->buildMenuIconsManialink($player);

2
application/core/Maps/MapList.php
View File

@@ -750,7 +750,7 @@ class MapList implements ManialinkPageAnswerListener, CallbackListener {
$player = $this->maniaControl->playerManager->getPlayer($login); $player = $this->maniaControl->playerManager->getPlayer($login);
if($player != null) { if($player != null) {
if($shown == self::SHOW_MX_LIST) { if($shown == self::SHOW_MX_LIST) {
//TODO //nothing to update yet
} else if($shown == self::SHOW_MAP_LIST) { } else if($shown == self::SHOW_MAP_LIST) {
$this->showMapList($player); $this->showMapList($player);
} }

13
application/core/Maps/MapQueue.php
View File

@@ -1,6 +1,7 @@
<?php <?php
namespace ManiaControl\Maps; namespace ManiaControl\Maps;
use ManiaControl\Callbacks\CallbackListener; use ManiaControl\Callbacks\CallbackListener;
use ManiaControl\Callbacks\CallbackManager; use ManiaControl\Callbacks\CallbackManager;
use ManiaControl\Commands\CommandListener; use ManiaControl\Commands\CommandListener;
@@ -52,6 +53,7 @@ class MapQueue implements CallbackListener, CommandListener {
/** /**
* Clears the map-queue via admin command clearmap queue * Clears the map-queue via admin command clearmap queue
*
* @param array $chat * @param array $chat
* @param Player $player * @param Player $player
*/ */
@@ -70,10 +72,11 @@ class MapQueue implements CallbackListener, CommandListener {
/** /**
* Adds a Map to the map-queue * Adds a Map to the map-queue
*
* @param $login * @param $login
* @param $uid * @param $uid
*/ */
public function addMapToMapQueue($login, $uid){ //TODO if from MX other message public function addMapToMapQueue($login, $uid) {
$player = $this->maniaControl->playerManager->getPlayer($login); $player = $this->maniaControl->playerManager->getPlayer($login);
//Check if the map is already juked //Check if the map is already juked
@@ -97,6 +100,7 @@ class MapQueue implements CallbackListener, CommandListener {
/** /**
* Revmoes a Map from the Map queue * Revmoes a Map from the Map queue
*
* @param $login * @param $login
* @param $uid * @param $uid
*/ */
@@ -107,6 +111,7 @@ class MapQueue implements CallbackListener, CommandListener {
/** /**
* Called on endmap * Called on endmap
*
* @param array $callback * @param array $callback
*/ */
public function endMap(array $callback) { public function endMap(array $callback) {
@@ -142,8 +147,9 @@ class MapQueue implements CallbackListener, CommandListener {
$this->nextMap = array_shift($this->queuedMaps); $this->nextMap = array_shift($this->queuedMaps);
//Check if Map Queue is empty //Check if Map Queue is empty
if($this->nextMap == null) if($this->nextMap == null) {
return; return;
}
$map = $this->nextMap[1]; $map = $this->nextMap[1];
@@ -156,13 +162,16 @@ class MapQueue implements CallbackListener, CommandListener {
/** /**
* Returns the next Map if the next map is a queuedmap or null if it's not * Returns the next Map if the next map is a queuedmap or null if it's not
*
* @return null * @return null
*/ */
public function getNextMap() { public function getNextMap() {
return $this->nextMap; return $this->nextMap;
} }
/** /**
* Returns a list with the indexes of the queued maps * Returns a list with the indexes of the queued maps
*
* @return array * @return array
*/ */
public function getQueuedMapsRanking() { public function getQueuedMapsRanking() {

1
application/core/Settings/SettingManager.php
View File

@@ -17,7 +17,6 @@ class SettingManager {
const TYPE_REAL = 'real'; const TYPE_REAL = 'real';
const TYPE_BOOL = 'bool'; const TYPE_BOOL = 'bool';
const TYPE_ARRAY = 'array'; const TYPE_ARRAY = 'array';
//const TYPE_AUTH_LEVEL = 'auth'; //TODO
/** /**
* Private properties * Private properties

2
application/core/Statistics/StatisticCollector.php
View File

@@ -56,7 +56,7 @@ class StatisticCollector implements CallbackListener {
//Initialize Settings //Initialize Settings
$this->maniaControl->settingManager->initSetting($this, self::SETTING_COLLECT_STATS_ENABLED, true); $this->maniaControl->settingManager->initSetting($this, self::SETTING_COLLECT_STATS_ENABLED, true);
$this->maniaControl->settingManager->initSetting($this, self::SETTING_COLLECT_STATS_MINPLAYERS, 1); //TODO TEMP on 1, normally 3 or 4 $this->maniaControl->settingManager->initSetting($this, self::SETTING_COLLECT_STATS_MINPLAYERS, 3);
$this->maniaControl->settingManager->initSetting($this, self::SETTING_ON_SHOOT_PRESTORE, 30); $this->maniaControl->settingManager->initSetting($this, self::SETTING_ON_SHOOT_PRESTORE, 30);
} }