minor cleanup

This commit is contained in:
kremsy
2014-02-13 00:46:41 +01:00
committed by Steffen Schröder
parent b1921fcc2b
commit 22707ea946
9 changed files with 61 additions and 59 deletions

View File

@ -172,7 +172,7 @@ class Configurator implements CallbackListener, CommandListener, ManialinkPageAn
$player = $callback[1];
$openedWidget = $callback[2];
//unset when another main widget got opened
if($openedWidget != 'Configurator') {
if ($openedWidget != 'Configurator') {
unset($this->playersMenuShown[$player->login]);
}
}
@ -203,7 +203,7 @@ class Configurator implements CallbackListener, CommandListener, ManialinkPageAn
* @param Player $player
*/
public function toggleMenu(Player $player) {
if(isset($this->playersMenuShown[$player->login])) {
if (isset($this->playersMenuShown[$player->login])) {
$this->hideMenu($player);
} else {
$this->showMenu($player);
@ -220,7 +220,7 @@ class Configurator implements CallbackListener, CommandListener, ManialinkPageAn
$i = 0;
foreach($this->menus as $menu) {
/** @var ConfiguratorMenu $menu */
if($menu->getTitle() == $name) {
if ($menu->getTitle() == $name) {
return $i;
}
$i++;
@ -279,7 +279,7 @@ class Configurator implements CallbackListener, CommandListener, ManialinkPageAn
$menuItemY = $menuHeight * 0.42;
$menuId = 0;
foreach($this->menus as $index => $menu) {
foreach($this->menus as $menu) {
/** @var ConfiguratorMenu $menu */
// Add title
@ -292,7 +292,7 @@ class Configurator implements CallbackListener, CommandListener, ManialinkPageAn
$menuItemLabel->setAction(self::ACTION_SELECTMENU . '.' . $menuId);
//Show a Menu
if($menuId == $menuIdShown) {
if ($menuId == $menuIdShown) {
$menuControl = $menu->getMenu($subMenuWidth, $subMenuHeight, $script);
$menusFrame->add($menuControl);
$script->addMenu($menuItemLabel, $menuControl);
@ -344,7 +344,7 @@ class Configurator implements CallbackListener, CommandListener, ManialinkPageAn
public function handleManialinkPageAnswer(array $callback) {
$actionId = $callback[1][2];
$boolSelectMenu = (strpos($actionId, self::ACTION_SELECTMENU) === 0);
if(!$boolSelectMenu) {
if (!$boolSelectMenu) {
return;
}

View File

@ -2,9 +2,7 @@
namespace ManiaControl\Configurators;
use FML\Script\Pages;
use FML\Script\Script;
use FML\Script\Tooltips;
use ManiaControl\Players\Player;
/**
@ -24,8 +22,8 @@ interface ConfiguratorMenu {
/**
* Get the Configurator Menu Frame
*
* @param float $width
* @param float $height
* @param float $width
* @param float $height
* @param Script $script
* @return \FML\Controls\Frame
*/
@ -34,7 +32,7 @@ interface ConfiguratorMenu {
/**
* Save the Config Data
*
* @param array $configData
* @param array $configData
* @param Player $player
*/
public function saveConfigData(array $configData, Player $player);

View File

@ -351,9 +351,9 @@ class ServerSettings implements ConfiguratorMenu, CallbackListener {
}
// Notifications
$settingsCount = count($newSettings);
$settingIndex = 0;
$title = $this->maniaControl->authenticationManager->getAuthLevelName($player->authLevel);
//$settingsCount = count($newSettings);
$settingIndex = 0;
//$title = $this->maniaControl->authenticationManager->getAuthLevelName($player->authLevel);
// $chatMessage = '$ff0' . $title . ' $<' . $player->nickname . '$> set ScriptSetting' . ($settingsCount > 1 ? 's' : '') . ' ';
foreach($newSettings as $setting => $value) {