added todo

removed unnecessary return
This commit is contained in:
Steffen Schröder 2014-03-31 22:05:54 +02:00
parent fd0d84dfb0
commit 142f84afd2
2 changed files with 2 additions and 5 deletions

View File

@ -404,9 +404,7 @@ class ScriptSettings implements ConfiguratorMenu, CallbackListener {
* @param bool * @param bool
*/ */
private function applyNewScriptSettings(array $newSettings, Player $player) { private function applyNewScriptSettings(array $newSettings, Player $player) {
if (!$newSettings) { if (!$newSettings) return true;
return true;
}
try { try {
$this->maniaControl->client->setModeScriptSettings($newSettings); $this->maniaControl->client->setModeScriptSettings($newSettings);
@ -449,8 +447,6 @@ class ScriptSettings implements ConfiguratorMenu, CallbackListener {
$statement->execute(); $statement->execute();
if ($statement->error) { if ($statement->error) {
trigger_error($statement->error); trigger_error($statement->error);
$statement->close();
return false;
} }
// Trigger own callback // Trigger own callback

View File

@ -342,6 +342,7 @@ class ServerSettings implements ConfiguratorMenu, CallbackListener {
} }
// Notifications // Notifications
//TODO: clean up those comments
//$settingsCount = count($newSettings); //$settingsCount = count($newSettings);
$settingIndex = 0; $settingIndex = 0;
//$title = $this->maniaControl->authenticationManager->getAuthLevelName($player->authLevel); //$title = $this->maniaControl->authenticationManager->getAuthLevelName($player->authLevel);