[TODO][CountdownMover] Prevent to catch Nadeo events to improve performance #9

New Issue

beu · 2023-09-08T21:40:45+02:00

beu commented

2023-09-08 21:40:45 +02:00

FYI this line in move countdown doesn't need true:
MLHook::RegisterMLHook(HookEvents, C_MLID_UIModuleUpdate + "_Update", true); -- the true here indicates that you're hooking a nadeo event (works for non nadeo events too), but it's there because it puts MLHook in a less efficient mode where all events are checked rather than just those with the MLHook prefix.
TBH, i think MLFeed does this anyway for the new records event, so probably not even worth worrying about.

https://discord.com/channels/276076890714800129/424967293538402334/1149492903517900901

		CountdownMover/main.as
		Line 66 in f7de2290cb
	
				    MLHook::RegisterMLHook(HookEvents, C_MLID_UIModuleUpdate + "_Update", true);

> FYI this line in move countdown doesn't need true: > MLHook::RegisterMLHook(HookEvents, C_MLID_UIModuleUpdate + "_Update", true); -- the true here indicates that you're hooking a nadeo event (works for non nadeo events too), but it's there because it puts MLHook in a less efficient mode where all events are checked rather than just those with the MLHook prefix. > TBH, i think MLFeed does this anyway for the new records event, so probably not even worth worrying about. https://discord.com/channels/276076890714800129/424967293538402334/1149492903517900901 https://git.virtit.fr/beu/Openplanet-Plugins/src/commit/f7de2290cb14076b337c8954d47a4454182f282b/CountdownMover/main.as#L66

Sign in to join this conversation.

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: beu/Openplanet-Plugins#9