From f6e39cfbe5ac287a70a64fb4d15ef7565fef1b1e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Steffen=20Schro=CC=88der?= <schteffens@gmail.com>
Date: Tue, 5 Aug 2014 01:51:59 +0200
Subject: [PATCH] removed Logger output parameter -> always do output!

---
 application/core/Logger.php | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/application/core/Logger.php b/application/core/Logger.php
index 719ed405..91dfa6ed 100644
--- a/application/core/Logger.php
+++ b/application/core/Logger.php
@@ -73,12 +73,11 @@ abstract class Logger {
 	 *
 	 * @param string $message
 	 * @param bool   $eol
-	 * @param bool   $output
 	 * @param bool   $stripCodes
 	 */
-	public static function logError($message, $eol = true, $output = true, $stripCodes = false) {
+	public static function logError($message, $eol = true, $stripCodes = false) {
 		$message = '[ERROR] ' . $message;
-		self::log($message, $eol, $output, $stripCodes);
+		self::log($message, $eol, $stripCodes);
 	}
 
 	/**
@@ -86,17 +85,14 @@ abstract class Logger {
 	 *
 	 * @param string $message
 	 * @param bool   $eol
-	 * @param bool   $output
 	 * @param bool   $stripCodes
 	 */
-	public static function log($message, $eol = true, $output = true, $stripCodes = false) {
+	public static function log($message, $eol = true, $stripCodes = false) {
 		if ($stripCodes) {
 			$message = Formatter::stripCodes($message);
 		}
 		error_log($message);
-		if ($output) {
-			self::output($message, $eol);
-		}
+		self::output($message, $eol);
 	}
 
 	/**
@@ -105,7 +101,7 @@ abstract class Logger {
 	 * @param string $message
 	 * @param bool   $eol
 	 */
-	public static function output($message, $eol = true) {
+	private static function output($message, $eol = true) {
 		if ($eol) {
 			$message = '[' . date('d-M-Y H:i:s e') . '] ' . $message . PHP_EOL;
 		}
@@ -117,12 +113,11 @@ abstract class Logger {
 	 *
 	 * @param string $message
 	 * @param bool   $eol
-	 * @param bool   $output
 	 * @param bool   $stripCodes
 	 */
-	public static function logInfo($message, $eol = true, $output = true, $stripCodes = false) {
+	public static function logInfo($message, $eol = true, $stripCodes = false) {
 		$message = '[INFO] ' . $message;
-		self::log($message, $eol, $output, $stripCodes);
+		self::log($message, $eol, $stripCodes);
 	}
 
 	/**
@@ -130,11 +125,10 @@ abstract class Logger {
 	 *
 	 * @param string $message
 	 * @param bool   $eol
-	 * @param bool   $output
 	 * @param bool   $stripCodes
 	 */
-	public static function logWarning($message, $eol = true, $output = true, $stripCodes = false) {
+	public static function logWarning($message, $eol = true, $stripCodes = false) {
 		$message = '[WARNING] ' . $message;
-		self::log($message, $eol, $output, $stripCodes);
+		self::log($message, $eol, $stripCodes);
 	}
 }