From d44f406933da6c21edd124dfd2253285bd6cb577 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Steffen=20Schro=CC=88der?= <schteffens@gmail.com>
Date: Thu, 1 May 2014 23:32:58 +0200
Subject: [PATCH] added todo

---
 application/core/Plugins/PluginManager.php | 2 +-
 application/core/Plugins/PluginMenu.php    | 2 +-
 application/core/Update/UpdateManager.php  | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/application/core/Plugins/PluginManager.php b/application/core/Plugins/PluginManager.php
index 66a66d29..e5aaed79 100644
--- a/application/core/Plugins/PluginManager.php
+++ b/application/core/Plugins/PluginManager.php
@@ -380,7 +380,7 @@ class PluginManager {
 	 * @param mixed $pluginClass
 	 * @return string
 	 */
-	private static function getPluginClass($pluginClass) {
+	public static function getPluginClass($pluginClass) {
 		if (is_object($pluginClass)) {
 			$pluginClass = get_class($pluginClass);
 		}
diff --git a/application/core/Plugins/PluginMenu.php b/application/core/Plugins/PluginMenu.php
index 84211569..6ea9891c 100644
--- a/application/core/Plugins/PluginMenu.php
+++ b/application/core/Plugins/PluginMenu.php
@@ -25,7 +25,7 @@ use ManiaControl\Players\Player;
 /**
  * Configurator for enabling and disabling Plugins
  *
- * @author steeffeen
+ * @author ManiaControl Team
  * @copyright ManiaControl Copyright © 2014 ManiaControl Team
  * @license http://www.gnu.org/licenses/ GNU General Public License, Version 3
  */
diff --git a/application/core/Update/UpdateManager.php b/application/core/Update/UpdateManager.php
index f7f2ad38..5ac7b4c0 100644
--- a/application/core/Update/UpdateManager.php
+++ b/application/core/Update/UpdateManager.php
@@ -14,6 +14,7 @@ use ManiaControl\Players\PlayerManager;
 use ManiaControl\Plugins\Plugin;
 use ManiaControl\Plugins\PluginInstallMenu;
 use ManiaControl\Plugins\PluginMenu;
+use ManiaControl\Plugins\PluginManager;
 
 /**
  * Manager checking for ManiaControl Core and Plugin Updates
@@ -430,15 +431,14 @@ class UpdateManager implements CallbackListener, CommandListener, TimerListener
 	 * @return mixed
 	 */
 	public function checkPluginUpdate($pluginClass) {
-		if (is_object($pluginClass)) {
-			$pluginClass = get_class($pluginClass);
-		}
+		$pluginClass = PluginManager::getPluginClass($pluginClass);
 		/**
 		 *
 		 * @var Plugin $pluginClass
 		 */
 		$pluginId = $pluginClass::getId();
 		$url = ManiaControl::URL_WEBSERVICE . 'plugins?id=' . $pluginId;
+		// TODO: asynchronous loading
 		$dataJson = FileUtil::loadFile($url);
 		$pluginVersions = json_decode($dataJson);
 		if (!$pluginVersions || !isset($pluginVersions[0])) {