From 861f9217b34c8caf0374c7adb7f1c5d3a7e31aeb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Steffen=20Schro=CC=88der?= <schteffens@gmail.com>
Date: Sun, 20 Jul 2014 00:19:54 +0200
Subject: [PATCH] improved phpdoc var statements

---
 application/plugins/MCTeam/Dedimania/DedimaniaData.php |  2 ++
 .../plugins/MCTeam/Dedimania/DedimaniaPlugin.php       | 10 ++--------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/application/plugins/MCTeam/Dedimania/DedimaniaData.php b/application/plugins/MCTeam/Dedimania/DedimaniaData.php
index 132a7328..b3674aa3 100644
--- a/application/plugins/MCTeam/Dedimania/DedimaniaData.php
+++ b/application/plugins/MCTeam/Dedimania/DedimaniaData.php
@@ -27,7 +27,9 @@ class DedimaniaData {
 	public $login;
 	public $code;
 	public $sessionId = '';
+	/** @var RecordData[] $records */
 	public $records = array();
+	/** @var DedimaniaPlayer[] $players */
 	public $players = array();
 	public $directoryAccessChecked = false;
 	public $serverMaxRank = 30;
diff --git a/application/plugins/MCTeam/Dedimania/DedimaniaPlugin.php b/application/plugins/MCTeam/Dedimania/DedimaniaPlugin.php
index 2b73be02..d41c9ff1 100644
--- a/application/plugins/MCTeam/Dedimania/DedimaniaPlugin.php
+++ b/application/plugins/MCTeam/Dedimania/DedimaniaPlugin.php
@@ -696,7 +696,6 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
 		$times    = array();
 		$replays  = array();
 		foreach ($this->dedimaniaData->records as $record) {
-			/** @var RecordData $record */
 			if ($record->rank > $this->dedimaniaData->serverMaxRank) {
 				break;
 			}
@@ -864,7 +863,6 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
 			if ($this->insertDedimaniaRecord($newRecord, $oldRecord)) {
 				// Get newly saved record
 				foreach ($this->dedimaniaData->records as &$record) {
-					/** @var RecordData $record */
 					if ($record->login !== $newRecord->login) {
 						continue;
 					}
@@ -900,12 +898,11 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
 	 * @return RecordData $record
 	 */
 	private function getDedimaniaRecord($login) {
-		if (!$this->dedimaniaData->records) {
+		if (!$this->dedimaniaData || !$this->dedimaniaData->records) {
 			return new RecordData(null);
 		}
 		$records = $this->dedimaniaData->records;
 		foreach ($records as &$record) {
-			/** @var RecordData $record */
 			if ($record->login === $login) {
 				return $record;
 			}
@@ -954,7 +951,6 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
 
 		// Loop through existing records
 		foreach ($this->dedimaniaData->records as $key => &$record) {
-			/** @var RecordData $record */
 			if ($record->rank > $maxRank) {
 				// Max rank reached
 				return false;
@@ -983,7 +979,6 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
 			if ($oldRecord) {
 				// Remove old record
 				foreach ($this->dedimaniaData->records as $key2 => $record2) {
-					/** @var RecordData $record2 */
 					if ($record2->login !== $oldRecord->login) {
 						continue;
 					}
@@ -1035,7 +1030,6 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
 		// Update ranks
 		$rank = 1;
 		foreach ($this->dedimaniaData->records as &$record) {
-			/** @var RecordData $record */
 			$record->rank = $rank;
 			$rank++;
 		}
@@ -1187,4 +1181,4 @@ class DedimaniaPlugin implements CallbackListener, CommandListener, TimerListene
 	 */
 	public function unload() {
 	}
-}
\ No newline at end of file
+}