From 4c2a5e3260d4c73592bb9ddf324971e84236e746 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steffen=20Schro=CC=88der?= Date: Fri, 13 Jun 2014 19:53:36 +0200 Subject: [PATCH] Revert "FileUtil::loadConfig now returns a DOMDocument" This reverts commit 58b07f266ccc36330be7a8390af3c6a71e0ee642. --- application/core/Files/FileUtil.php | 25 +++++-------------------- application/core/ManiaControl.php | 4 ++-- 2 files changed, 7 insertions(+), 22 deletions(-) diff --git a/application/core/Files/FileUtil.php b/application/core/Files/FileUtil.php index 82844f92..1166eafd 100644 --- a/application/core/Files/FileUtil.php +++ b/application/core/Files/FileUtil.php @@ -68,37 +68,22 @@ abstract class FileUtil { } /** - * Load the Config XML-File with the given Name + * Load config xml-file * * @param string $fileName - * @return \DOMElement + * @return \SimpleXMLElement */ public static function loadConfig($fileName) { $fileLocation = ManiaControlDir . 'configs' . DIRECTORY_SEPARATOR . $fileName; if (!file_exists($fileLocation)) { - logMessage("Config file doesn't exist! ('{$fileName}')"); + logMessage("Config File doesn't exist! ({$fileName})"); return null; } if (!is_readable($fileLocation)) { - logMessage("Config file isn't readable! Please check the file permissions. ('{$fileName}')"); + logMessage("Config File isn't readable! Please check the File Permissions. ({$fileName})"); return null; } - $configFileContent = @file_get_contents($fileLocation); - if (!$configFileContent) { - trigger_error("Couldn't load config file! ('{$fileName}')"); - return null; - } - $domDocument = new \DOMDocument(); - if (!@$domDocument->loadXML($configFileContent)) { - $message = "Config file isn't maintained properly! ('{$fileName}')"; - $error = error_get_last(); - if ($error && stripos($error['message'], 'DOMDocument::loadXML()') === 0) { - $message .= PHP_EOL . $error['message']; - } - trigger_error($message); - return null; - } - return $domDocument->firstChild; + return simplexml_load_file($fileLocation); } /** diff --git a/application/core/ManiaControl.php b/application/core/ManiaControl.php index 15d65105..d052af7a 100644 --- a/application/core/ManiaControl.php +++ b/application/core/ManiaControl.php @@ -65,7 +65,7 @@ class ManiaControl implements CommandListener, TimerListener { public $authenticationManager = null; public $callbackManager = null; public $chat = null; - /** @var \DOMElement $config */ + /** @var \SimpleXMLElement $config */ public $config = null; public $configurator = null; /** @var Connection $client */ @@ -160,7 +160,7 @@ class ManiaControl implements CommandListener, TimerListener { if (!$this->config) { $this->quit("Error loading Configuration XML-File! ('{$configFileName}')", true); } - if ($this->config->childNodes->length < 3) { + if ($this->config->count() < 3) { $this->quit("Your Configuration File ('{$configFileName}') doesn't seem to be maintained properly. Please check it again!", true); } }